Migrated `app.config.chain.getById()` calls to newer `trpc.community.getCommunity()` + cleanup/state-refactor of related components #8779

mzparacha · 2024-08-07T01:13:47Z

Link to Issue

Closes: #8762

Description of Changes

Removed all app.config.chains.getById references in favor of newer trpc.community.getCommunity route
Refactored multiple frontend modules to cleanup/abstract/simplify logic relating to community state.
Refactored frontend chain init according to /bulkOffchain API merged in trpc.community.getCommunity route
Reduced usage of ChainInfo object usage

"How We Fixed It"

N/A

Test Plan

We have to ensure nothing that referenced app.config.chain.getById() broke

Test all community pages including gated/restricted/special-case pages/actions like snapshots/contests/admin-pages/token-gating/stakes for any regressions
Test non-community pages specially profile/feed/notifications page for any regressions
Test site admin page for any regressions

Deployment Plan

N/A

Other Considerations

The changes in this pr will lead to some more cleanup/refinement. Created these tickets to make those changes as a follow-up.

…yIdQuery`

…tCommunityByIdQuery`

…yByIdQuery`

…cified condition

…e community with RQ"

…ery`

…y`+ update community with RQ

…useGetCommunityByIdQuery`

…ching community data

masvelio

half way through 😓
now going to do some manual testing

packages/commonwealth/client/scripts/hooks/useRunOnceOnCondition.ts

packages/commonwealth/client/scripts/models/IChainAdapter.ts

packages/commonwealth/client/scripts/state/api/communities/getCommuityById.ts

packages/commonwealth/client/scripts/views/components/sidebar/external_links_module.tsx

...onwealth/client/scripts/views/modals/ManageCommunityStakeModal/ManageCommunityStakeModal.tsx

masvelio

getting this error on dashboard page load

[13:22:00.257] ERROR (index.ts): INTERNAL_SERVER_ERROR: [ZodError] subscription.getCommentSubscriptions: [
  {
    "code": "invalid_type",
    "expected": "object",
    "received": "null",
    "path": [
      0,
      "Comment",
      "Thread"
    ],
    "message": "Expected object, received null"
  }
] 
    err: {
      "type": "ZodError",
      "message": "[\n  {\n    \"code\": \"invalid_type\",\n    \"expected\": \"object\",\n    \"received\": \"null\",\n    \"path\": [\n      0,\n      \"Comment\",\n      \"Thread\"\n    ],\n    \"message\": \"Expected object, received null\"\n  }\n]",
      "stack":
          ZodError: [
            {
              "code": "invalid_type",
              "expected": "object",
              "received": "null",
              "path": [
                0,
                "Comment",
                "Thread"
              ],
              "message": "Expected object, received null"
            }
          ]
              at get error [as error] (file:///Users/marcin/Desktop/Projects/commonwealth/node_modules/.pnpm/[email protected]/node_modules/zod/lib/index.mjs:587:31)
              at ZodArray.parseAsync (file:///Users/marcin/Desktop/Projects/commonwealth/node_modules/.pnpm/[email protected]/node_modules/zod/lib/index.mjs:715:22)
              at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
              at async outputMiddleware (file:///Users/marcin/Desktop/Projects/commonwealth/node_modules/.pnpm/@[email protected]/node_modules/@trpc/server/dist/index.mjs:308:26)
              at async callRecursive (file:///Users/marcin/Desktop/Projects/commonwealth/node_modules/.pnpm/@[email protected]/node_modules/@trpc/server/dist/index.mjs:451:32)
              at async callRecursive (file:///Users/marcin/Desktop/Projects/commonwealth/node_modules/.pnpm/@[email protected]/node_modules/@trpc/server/dist/index.mjs:451:32)
              at async resolve (file:///Users/marcin/Desktop/Projects/commonwealth/node_modules/.pnpm/@[email protected]/node_modules/@trpc/server/dist/index.mjs:481:24)
              at async inputToProcedureCall (file:///Users/marcin/Desktop/Projects/commonwealth/node_modules/.pnpm/@[email protected]/node_modules/@trpc/server/dist/resolveHTTPResponse-2fc435bb.mjs:46:22)
              at async Promise.all (index 0)
              at async resolveHTTPResponse (file:///Users/marcin/Desktop/Projects/commonwealth/node_modules/.pnpm/@[email protected]/node_modules/@trpc/server/dist/resolveHTTPResponse-2fc435bb.mjs:182:37)
      "aggregateErrors": [
        {
          "type": "Object",
          "message": "Expected object, received null",
          "stack":
              
          "code": "invalid_type",
          "expected": "object",
          "received": "null",
          "path": [
            0,
            "Comment",
            "Thread"
          ]
        }
      ],
      "issues": [
        {
          "code": "invalid_type",
          "expected": "object",
          "received": "null",
          "path": [
            0,
            "Comment",
            "Thread"
          ],
          "message": "Expected object, received null"
        }
      ],
      "name": "ZodError"
    }

this api cal looks weird (maybe it is ok but just want to double check)
Filtering by stake does not work

getting stake error on community load

Actually nothing related to stake does not work, I can't see indicator in left sidebar
infinite loader on create community flow when reserving namespace

community I just created -> I am not admin of this community, cannot see admin capabilities section

search throws backend errors

mzparacha · 2024-08-13T16:06:29Z

Re: #8779 (review)

This is on the master branch as well -- this is some "types" issue on the API side -- I believe Kevin is working on the fix in Fixed bug where unauthenticated users would get subscription errors in the console. #8833
normal - trpc batches multiple requests (if different calls are made in a short timespan) -- the caches of responses are managed normally
Fixed in 7a050be
Fixed in 4521354
This is on the master branch as well - will create a new ticket to investigate -
Fixed in 6b3889a
This seems to be a "types" issue with the get community route. Basically the community.network is typed with ChainNetwork, and ChainNetwork doesn't include all the networks that communities in db might have. Ex: Regen is not listed in ChainNetwork but exists in the Communities table, visiting the regen community would break the route http://localhost:8080/api/v1/community.getCommunity?batch=1&input=%7B%220%22%3A%7B%22id%22%3A%22regen%22%2C%22include_node_info%22%3Atrue%7D%7D. I found ~59 more networks in my local db not listed in ChainNetwork and suspect there are probably more in prod db. We should list all those in ChainNetwork or maybe change/remove the type.

mzparacha · 2024-08-13T17:58:09Z

@masvelio Thanks for the detailed review. I addressed all the feedback in #8779 (comment)

Also cc: @jnaviask - point 7 in #8779 (comment) relates to the chain network issues we discussed.

masvelio

Zod validation error on communities page

Kapture.2024-08-14.at.10.27.03.mp4

Tested issues I found yesterday, work well now, thanks for fixing them. Added couple small comments + found 1 issue with zod validation. Apart from that, looks good to me. Fantastic job!

packages/commonwealth/client/scripts/views/pages/DirectoryPage/CommunityDirectoryCard/index.tsx

packages/commonwealth/client/scripts/views/pages/NotificationSettingsOld/SubscriptionEntry.tsx

mzparacha · 2024-08-14T13:57:16Z

Re: #8779 (review)

Zod validation error on communities page

This also relates to 7 in #8779 (comment)

cc: @masvelio @jnaviask

…ork-enum-type Convert ChainNetwork type to string.

mzparacha · 2024-08-14T18:46:13Z

The 7 from #8779 (comment) was fixed in #8843 -- Thanks to @jnaviask

jnaviask · 2024-08-14T19:51:43Z

Member count seems broken on the /members page but otherwise this PR seems good to me.

jnaviask

Members issue looks like it's my machine and not part of this PR.

mzparacha added 30 commits August 7, 2024 04:29

Refactored AdminOnboardingSlider.tsx to use useGetCommunityByIdQuery

5ff429b

Refactored CWSearchBar.tsx to use useGetCommunityByIdQuery

b8b1f97

Refactored DirectoryMenuItem.tsx to use useGetCommunityByIdQuery

66fd74a

Refactored ProfileActivityRow.tsx to use useGetCommunityByIdQuery

eeb8778

Refactored feed.tsx to use useGetCommunityByIdQuery

bdce093

Refactored AllowList.tsx to use useGetCommunityByIdQuery

809d835

Refactored Tag.showcase.tsx to use useGetCommunityByIdQuery

f935055

Removed app.chain.getById from Webhooks.tsx

a102079

Refactored AuthorAndPublishInfo.tsx to use useGetCommunityByIdQuery

f3ae371

Refactored pages/notification/* components to use `useGetCommunityB…

448c6aa

…yIdQuery`

Refactored helper components for old notifications page to use `useGe…

835adb4

…tCommunityByIdQuery`

Refactored view_multiple_snapshots/index.tsx to use `useGetCommunit…

f6fde81

…yByIdQuery`

Refactored CommunityMembersPage.tsx to use useGetCommunityByIdQuery

b968fb1

Refactored DirectoryPage.tsx to use useGetCommunityByIdQuery

b9156ca

Refactored to use + update community with RQ

e6140f0

Added useRunOnceOnCondition() which runs once/comp-lifecycle on spe…

f1b7563

…cified condition

"Refactored CustomTOS.tsx to use useGetCommunityByIdQuery + updat…

5038f96

…e community with RQ"

"Refactored Directory.tsx to use useGetCommunityByIdQuery + updat…

89f2bce

…e community with RQ"

"Refactored Snapshots.tsx to use useGetCommunityByIdQuery + updat…

0aa6999

…e community with RQ"

Moved link categorization logic from ChainInfo.ts to helpers/link.ts

7f6ce20

"Refactored external_links_module.tsx to use `useGetCommunityByIdQu…

4871053

…ery`

Refactored valid-link check logic

b167102

Fix valid-link check bug with getLinkType() helper

4b1c004

Removed app.config.chain.getById form notifications/helpers.tsx

e8a53cf

Refactored CommunityProfileForm.tsx to use `useGetCommunityByIdQuer…

2d4677d

…y`+ update community with RQ

Refactored CWRelatedCommunityCard.tsx and stake components to use `…

12ada74

…useGetCommunityByIdQuery`

Removed app.config.chain.getById from AllowList.tsx

e33706b

Removed app.config.chain.getById from CommunityMembersPage.tsx

08e7f17

Refactored Analytics.tsx to use useGetCommunityByIdQuery

615d5e6

Refactored DeleteChainTask.tsx to use CommunityFinder.tsx for fet…

9afb1ca

…ching community data

mzparacha added 4 commits August 13, 2024 03:15

Removed unnecessary todos

88e0cb5

Updated community profile form to update banner text

9957063

Fix lint issues

38a0382

Fix lint

fa83e74

masvelio reviewed Aug 13, 2024

View reviewed changes

mzparacha added 5 commits August 13, 2024 18:30

Merge branch 'master' into malik.8762.community-by-id

e1390a7

Removed clients/scipts path from file imports

84a68b9

Update todo comment about 1inch dark mode

534417a

Display slack links in community sidebar as normal links

428c382

Fix permission check for community admins

6b3889a

jnaviask temporarily deployed to commonwealth-frick August 13, 2024 16:47 Inactive

mzparacha added 2 commits August 13, 2024 22:07

Fix staked community crashing

4521354

Fix stake filter in communities list page

7a050be

masvelio approved these changes Aug 14, 2024

View reviewed changes

packages/commonwealth/client/scripts/views/pages/DirectoryPage/CommunityDirectoryCard/index.tsx Outdated Show resolved Hide resolved

packages/commonwealth/client/scripts/views/pages/NotificationSettingsOld/SubscriptionEntry.tsx Show resolved Hide resolved

Update dir structure for CommunityDirectoryCard

b0cacd3

Convert ChainNetwork type to string.

d9ddd2b

jnaviask mentioned this pull request Aug 14, 2024

Convert ChainNetwork type to string. #8843

Merged

jnaviask and others added 2 commits August 14, 2024 14:33

Fix typeerror.

9048ed9

Merge pull request #8843 from hicommonwealth/jake.8762.eliminate-netw…

5f9aa16

…ork-enum-type Convert ChainNetwork type to string.

jnaviask mentioned this pull request Aug 14, 2024

Remove substrate_spec field on communities. #8846

Merged

Merge branch 'master' into malik.8762.community-by-id

37647c6

jnaviask approved these changes Aug 14, 2024

View reviewed changes

jnaviask merged commit 483f6d4 into master Aug 14, 2024
9 checks passed

mzparacha mentioned this pull request Aug 20, 2024

Fixed community switching for auth user #8915

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrated `app.config.chain.getById()` calls to newer `trpc.community.getCommunity()` + cleanup/state-refactor of related components #8779

Migrated `app.config.chain.getById()` calls to newer `trpc.community.getCommunity()` + cleanup/state-refactor of related components #8779

mzparacha commented Aug 7, 2024 •

edited

Loading

masvelio left a comment

masvelio left a comment

mzparacha commented Aug 13, 2024 •

edited

Loading

mzparacha commented Aug 13, 2024

masvelio left a comment

mzparacha commented Aug 14, 2024

mzparacha commented Aug 14, 2024

jnaviask commented Aug 14, 2024

jnaviask left a comment

Migrated app.config.chain.getById() calls to newer trpc.community.getCommunity() + cleanup/state-refactor of related components #8779

Migrated app.config.chain.getById() calls to newer trpc.community.getCommunity() + cleanup/state-refactor of related components #8779

Conversation

mzparacha commented Aug 7, 2024 • edited Loading

Link to Issue

Description of Changes

"How We Fixed It"

Test Plan

Deployment Plan

Other Considerations

masvelio left a comment

Choose a reason for hiding this comment

masvelio left a comment

Choose a reason for hiding this comment

mzparacha commented Aug 13, 2024 • edited Loading

mzparacha commented Aug 13, 2024

masvelio left a comment

Choose a reason for hiding this comment

mzparacha commented Aug 14, 2024

mzparacha commented Aug 14, 2024

jnaviask commented Aug 14, 2024

jnaviask left a comment

Choose a reason for hiding this comment

Migrated `app.config.chain.getById()` calls to newer `trpc.community.getCommunity()` + cleanup/state-refactor of related components #8779

Migrated `app.config.chain.getById()` calls to newer `trpc.community.getCommunity()` + cleanup/state-refactor of related components #8779

mzparacha commented Aug 7, 2024 •

edited

Loading

mzparacha commented Aug 13, 2024 •

edited

Loading